Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the recently released SuiteSparse 7.5.0.
This allows for us to drop the build system patch, since that was already upstream, so now we link against blastrampoline properly with no patches. Looking through the Windows build logs, I did see the warning
which ends up being because SuiteSparse tries to make a define for
-DBLAS_blastrampoline-5
, and the-
is an illegal character. I modified it so the library name is passed in without the version suffix to the define, but the linkers still get the suffix, so this command line warning is gone now.Also, @rayegun, it looks like this update will be good for your work to add the Float32 support to the SuiteSparse wrapper: