Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuiteSparse] Update to 7.5.0 #7931

Merged
merged 1 commit into from
Jan 11, 2024
Merged

[SuiteSparse] Update to 7.5.0 #7931

merged 1 commit into from
Jan 11, 2024

Conversation

imciner2
Copy link
Member

Update to the recently released SuiteSparse 7.5.0.

This allows for us to drop the build system patch, since that was already upstream, so now we link against blastrampoline properly with no patches. Looking through the Windows build logs, I did see the warning

<command-line>:0:20: warning: ISO C99 requires whitespace after the macro name [enabled by default]

which ends up being because SuiteSparse tries to make a define for -DBLAS_blastrampoline-5, and the - is an illegal character. I modified it so the library name is passed in without the version suffix to the define, but the linkers still get the suffix, so this command line warning is gone now.

Also, @rayegun, it looks like this update will be good for your work to add the Float32 support to the SuiteSparse wrapper:

CHOLMOD 5.1.1 appears in SuiteSparse 7.5.0 (a stable release). It's essentially finished, in terms of support for single precision. It could use a method for creating a copy of a sparse matrix, dense matrix, triplet matrix, or factorization, while at the same time converting between single and double precision (see issue DrTimothyAldenDavis/SuiteSparse#720, which I'll consider for a future version of CHOLMOD), but otherwise it's in good shape.

@rayegun
Copy link
Contributor

rayegun commented Jan 11, 2024

Great thank you. I will also look at the CUDA version so we can add function stubs. I think I can use Cyclops to test

@imciner2 imciner2 merged commit b43770c into master Jan 11, 2024
14 checks passed
@imciner2 imciner2 deleted the im/ss75 branch January 11, 2024 11:56
grasph pushed a commit to Moelf/Yggdrasil that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants